Arcana Auth SDK support #1744

mmjee · 2023-05-26T06:07:28Z

Description

Added a package to support the Arcana Auth SDK. See the included documentation for more information.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
Check the box that allows repo maintainers to update this PR
Test locally to make sure this feature/fix works
Run yarn check-all to confirm there are not any associated errors
Confirm this PR passes Circle CI checks
Add or update relevant information in the documentation

Docs Checklist

Include a screenshot of any changes (see docs README on running locally)
Add/update the appropriate package README (if applicable)
Add/update the related module in the docs demo (if applicable)
Add/update the related package in the docs/package.json file (if applicable)

Added documentation for the new package.

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected) – Not relevant

Tests with demo app (SDK)

vercel · 2023-05-26T06:07:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web3-onboard-docs	❌ Failed (Inspect)			Jun 28, 2023 5:42am

socket-security · 2023-05-26T06:12:10Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

mmjee · 2023-05-26T06:20:04Z

So, how is the documentation package supposed to install a unpublished package? Should I split this into two PRs, so that the package can be published first?

packages/arcana-auth/package.json

packages/demo/package.json

docs/package.json

leightkt · 2023-05-31T17:16:49Z

@mmjee Overall- looking good.
Don't worry about the docs not building- we can check the docs when the alpha package is published on merge into develop.
I tested in the demo and was able to connect, disconnect, sign a message, and sign a typed message. However- I could not send a Goerli transaction- video of my test: https://www.loom.com/share/f95f53bfd01c404e9d816876ec1e1eb6

mmjee · 2023-06-01T05:18:17Z

@mmjee Overall- looking good. Don't worry about the docs not building- we can check the docs when the alpha package is published on merge into develop. I tested in the demo and was able to connect, disconnect, sign a message, and sign a typed message. However- I could not send a Goerli transaction- video of my test: https://www.loom.com/share/f95f53bfd01c404e9d816876ec1e1eb6

I tried to reproduce the above issue but I couldn't actually get it to switch to Görli because of Infura (and the API key is hardcoded).

leightkt · 2023-06-02T20:35:18Z

you can update the goerli rpc url in packages/demo/src/App.svelte
https://ethereum-goerli.publicnode.com

I'll make a note to update that in our demo

mmjee · 2023-06-05T04:57:23Z

@leightkt Updated the RPC URL, it should work assuming you have Görli ETH in the address.

leightkt · 2023-06-05T16:19:42Z

@mmjee I still get the same 'UNSUPPORTED_OPERATION' error shown in my testing video above (able to switch to goerli, have test ETH in my account)

socket-security · 2023-06-27T07:57:22Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
typescript	5.1.6	None	`+0`	40.1 MB	typescript-bot
@arcana/auth	1.0.6	network	`+1`	297 kB	makyl

leightkt · 2023-06-27T17:04:47Z

@mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx!

mmjee · 2023-06-27T17:10:37Z

On 6/27/23 22:34, Kat Leight wrote: @mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx!

Yes, it looks like we are mishandling EIP-1559 transactions so this is blocked until we figure out what the problem is and fix it. -- Regards,

mmjee · 2023-07-25T07:45:27Z

@leightkt Can you confirm whether the issue above still occurs?

leightkt · 2023-07-25T21:09:37Z

@mmjee I can no longer connect to the wallet

mmjee · 2023-07-26T06:43:50Z

@mmjee I can no longer connect to the wallet

Updated the packages, should be working now. Works locally.

leightkt · 2023-07-26T16:20:00Z

mmjee · 2023-07-27T06:57:14Z

On ২৬/৭/২৩ ২১:৫০, Kat Leight wrote: <img width="1344" alt="Screenshot 2023-07-26 at 10 17 12 AM" src="https://github.com/blocknative/web3-onboard/assets/33187102/8f9fc31b-5430-4616-aaf5-bdf7bf82cb39">

Do you see anything in the DevTools Network Tab? This is a web wallet so everything should be loaded in dynamically. Does that work on a browser w/o extensions? I can confirm it works locally. -- Regards,

leightkt · 2023-07-27T21:43:30Z

@mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README that this is expected behavior

Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet.

I cannot send a Transaction on Goerli:

mmjee · 2023-08-01T15:27:52Z

On 7/28/23 03:13, Kat Leight wrote: @mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README

Arcana Auth is supposed to work with all popular browsers and works even when 3rd party cookies are blocked. It should work by default for most browsers even with extensions. If you can, please narrow it down to an extension and/or configuration that could be causing it.

Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet. I cannot send a Transaction on Goerli: ![Screenshot 2023-07-27 at 3 42 08 PM](https://github.com/blocknative/web3-onboard/assets/33187102/b8e83f4f-3e41-4ff5-9f64-ca8c28ed1bea) ![Screenshot 2023-07-27 at 3 42 11 PM](https://github.com/blocknative/web3-onboard/assets/33187102/491eb55f-1814-4ee9-abad-c4f579545f47)

Can you please retry again? We have added a few more fixes to EIP-1559 transaction handling. -- Regards,

leightkt · 2023-08-01T16:35:40Z

@mmjee success! Please add a note to the the Arcana readme and docs page that users may need to disable other wallet extensions in order to connect to Arcana.

Also- the Arcana docs page needs to be moved to [..1]arcana to respect alpha order. I can push that change (and handle the renaming of the other docs pages to keep the order) if you want to give me write access.

Once those two things are completed it's good to go!

shaloo · 2023-08-02T04:53:42Z

@mmjee success! Please add a note to the the Arcana readme and docs page that users may need to disable other wallet extensions in order to connect to Arcana.

Also- the Arcana docs page needs to be moved to [..1]arcana to respect alpha order. I can push that change (and handle the renaming of the other docs pages to keep the order) if you want to give me write access.

Once those two things are completed it's good to go!

Got it, fixing docs and readme as suggested above. cc: @mmjee @leightkt

mmjee · 2023-08-02T12:34:25Z

@leightkt All changes are ready to be reviewed.

leightkt · 2023-08-02T17:49:02Z

@mmjee getting an error on our circleci build- please put up a new PR to fix.

mmjee · 2023-08-03T07:15:14Z

@leightkt Should be fixed by #1860.

* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update Arcana Auth SDK version (#1860) * update arcana/demo packages and root version * add ts-ignore for arcana * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: mmjee <root@git.maharshi.ninja>

* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update Arcana Auth SDK version (#1860) * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * Release 2.24.7 (develop) (#1863) * update arcana/demo packages and root version * add ts-ignore for arcana * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Bump WC deps to the latest (#1866) * Update docs for Base main (#1868) --------- Co-authored-by: mmjee <root@git.maharshi.ninja> Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>

vercel bot had a problem deploying to Preview May 26, 2023 06:07 Failure

mmjee marked this pull request as ready for review May 26, 2023 06:19

leightkt reviewed May 31, 2023

View reviewed changes

packages/arcana-auth/package.json Outdated Show resolved Hide resolved

leightkt reviewed May 31, 2023

View reviewed changes

packages/demo/package.json Outdated Show resolved Hide resolved

leightkt reviewed May 31, 2023

View reviewed changes

docs/package.json Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview June 1, 2023 04:56 Failure

mmjee force-pushed the feature/arcana-auth branch from 9e17acc to 8ff5d62 Compare June 1, 2023 04:59

vercel bot had a problem deploying to Preview June 1, 2023 04:59 Failure

mmjee requested a review from leightkt June 2, 2023 13:09

vercel bot had a problem deploying to Preview June 5, 2023 04:57 Failure

vercel bot had a problem deploying to Preview June 5, 2023 05:00 Failure

vercel bot had a problem deploying to Preview June 27, 2023 07:51 Failure

leightkt marked this pull request as draft June 27, 2023 17:04

vercel bot had a problem deploying to Preview June 28, 2023 05:42 Failure

mmjee marked this pull request as ready for review July 25, 2023 07:45

mmjee force-pushed the feature/arcana-auth branch from 0998469 to a736a1a Compare July 26, 2023 06:43

Arcana Auth SDK support

91401c6

mmjee force-pushed the feature/arcana-auth branch from c789e7e to 91401c6 Compare August 2, 2023 12:32

leightkt approved these changes Aug 2, 2023

View reviewed changes

leightkt merged commit 5aec48b into blocknative:develop Aug 2, 2023

This was referenced Aug 3, 2023

Release 2.24.7 (develop) #1863

Merged

Release 2.24.7 #1864

Merged

Release 2.24.7 (docs) #1865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arcana Auth SDK support #1744

Arcana Auth SDK support #1744

mmjee commented May 26, 2023

vercel bot commented May 26, 2023 •

edited

Loading

socket-security bot commented May 26, 2023 •

edited

Loading

mmjee commented May 26, 2023

leightkt commented May 31, 2023

mmjee commented Jun 1, 2023

leightkt commented Jun 2, 2023 •

edited

Loading

mmjee commented Jun 5, 2023

leightkt commented Jun 5, 2023

socket-security bot commented Jun 27, 2023 •

edited

Loading

leightkt commented Jun 27, 2023

mmjee commented Jun 27, 2023 via email

mmjee commented Jul 25, 2023

leightkt commented Jul 25, 2023

mmjee commented Jul 26, 2023

leightkt commented Jul 26, 2023

mmjee commented Jul 27, 2023 via email

leightkt commented Jul 27, 2023 •

edited

Loading

mmjee commented Aug 1, 2023 via email

leightkt commented Aug 1, 2023

shaloo commented Aug 2, 2023

mmjee commented Aug 2, 2023

leightkt commented Aug 2, 2023 •

edited

Loading

mmjee commented Aug 3, 2023

Arcana Auth SDK support #1744

Arcana Auth SDK support #1744

Conversation

mmjee commented May 26, 2023

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

Docs Checklist

If this PR includes changes to add an injected wallet or SDK wallet module:

Tests with demo app (injected) – Not relevant

Tests with demo app (SDK)

vercel bot commented May 26, 2023 • edited Loading

socket-security bot commented May 26, 2023 • edited Loading

mmjee commented May 26, 2023

leightkt commented May 31, 2023

mmjee commented Jun 1, 2023

leightkt commented Jun 2, 2023 • edited Loading

mmjee commented Jun 5, 2023

leightkt commented Jun 5, 2023

socket-security bot commented Jun 27, 2023 • edited Loading

leightkt commented Jun 27, 2023

mmjee commented Jun 27, 2023 via email

mmjee commented Jul 25, 2023

leightkt commented Jul 25, 2023

mmjee commented Jul 26, 2023

leightkt commented Jul 26, 2023

mmjee commented Jul 27, 2023 via email

leightkt commented Jul 27, 2023 • edited Loading

mmjee commented Aug 1, 2023 via email

leightkt commented Aug 1, 2023

shaloo commented Aug 2, 2023

mmjee commented Aug 2, 2023

leightkt commented Aug 2, 2023 • edited Loading

mmjee commented Aug 3, 2023

vercel bot commented May 26, 2023 •

edited

Loading

socket-security bot commented May 26, 2023 •

edited

Loading

leightkt commented Jun 2, 2023 •

edited

Loading

socket-security bot commented Jun 27, 2023 •

edited

Loading

leightkt commented Jul 27, 2023 •

edited

Loading

leightkt commented Aug 2, 2023 •

edited

Loading