Feature- update appMetadata #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
Adamj1232
reviewed
Jun 15, 2023
packages/core/src/index.ts
Outdated
| @@ -217,6 +218,8 @@ function init(options: InitOptions): OnboardAPI { | |||
| unstoppableResolution | |||
| }) | |||
|
|
|||
| updateAppMetadata(appMetadata) | |||
There was a problem hiding this comment.
I think we need an undefined check here and remove the default null initializer on ln 95
Adamj1232
reviewed
Jun 15, 2023
Adamj1232
reviewed
Jun 16, 2023
packages/demo/src/App.svelte
Outdated
| gettingStartedGuide: 'https://blocknative.com', | ||
| explore: 'https://blocknative.com' | ||
| }, | ||
| // appMetadata: { |
There was a problem hiding this comment.
This can be commented back in
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
This was referenced Jun 27, 2023
Merged
Merged
leightkt
added a commit
that referenced
this pull request
Jun 27, 2023
* update Google Analytics Script (#1770) * feat: add OneKey wallet (#1739) * feat: Support OneKey wallet * fix: OneKey docs * Update injected package.json version * Update demo package.json --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Fix: Connect view on safari mobile & Remove unnecessary validation check for autoSelect (#1773) * working as expected * Bump versions * Remove testing css * Remove testing code from demo * feat: add blocto wallet (#1699) * Release 2.24.1 (develop) (#1776) * Release 2.24.1 (docs) (#1778) * Update +page.md (#1775) * Feature- update appMetadata (#1779) * update versions * Upgrade wallet connect v2 packages (#1788) --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: jimmy.pan <pan831225@gmail.com> Co-authored-by: vanes <vanessa.mercado24@gmail.com>
leightkt
added a commit
that referenced
this pull request
Jun 27, 2023
* update Google Analytics Script (#1770) * feat: add OneKey wallet (#1739) * feat: Support OneKey wallet * fix: OneKey docs * Update injected package.json version * Update demo package.json --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Fix: Connect view on safari mobile & Remove unnecessary validation check for autoSelect (#1773) * working as expected * Bump versions * Remove testing css * Remove testing code from demo * feat: add blocto wallet (#1699) * Release 2.24.1 (develop) (#1776) * Release 2.24.1 (#1777) * Update +page.md (#1775) * Feature- update appMetadata (#1779) * update versions * Upgrade wallet connect v2 packages (#1788) --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: jimmy.pan <pan831225@gmail.com> Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for the updating of appMetadata after initialization
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)