Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Capsule Integration to Blocknative #2005

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

vr2amesh
Copy link
Contributor

@vr2amesh vr2amesh commented Nov 20, 2023

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Copy link

socket-security bot commented Nov 20, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@usecapsule/web-sdk 0.29.4 network +184 95.6 MB
@types/react 18.2.39 None +3 1.55 MB types
react-dom 17.0.2 None +1 3.1 MB gaearon
@wagmi/chains 1.8.0 None +0 319 kB jmoxey

🚮 Removed packages: @walletconnect/ethereum-provider@2.10.5, @walletconnect/types@2.10.5

@vr2amesh vr2amesh marked this pull request as ready for review November 20, 2023 20:42
@vr2amesh
Copy link
Contributor Author

Screenshot 2023-11-07 at 5 51 45 PM

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for contributing!

@Adamj1232 Adamj1232 merged commit c5151d5 into blocknative:develop Nov 29, 2023
3 checks passed
@Adamj1232 Adamj1232 changed the title Capsule Integration to Blocknative Feature: Capsule Integration to Blocknative Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants