Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect 2.5.2-alpha.1 : [fix] - Remove unnecessary WC module that was causing issues in usage of module #2020

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Dec 8, 2023

Description

Remove the @walletconnect/modal dep from the WalletConnect module on recommendation from the WC team as it was causing issue with communicating to the WC servers'

In ref to #2019

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@Adamj1232 Adamj1232 requested a review from leightkt December 8, 2023 17:08
@Adamj1232 Adamj1232 merged commit 405704e into develop Dec 8, 2023
3 checks passed
@Adamj1232 Adamj1232 deleted the fix/wc_remove_outdated_deps_breaking branch December 8, 2023 17:22
@Adamj1232 Adamj1232 changed the title 2.5.2-alpha.1 WalletConnect : [fix] - Remove unnecessary WC module that was causing issues in usage of module WalletConnect 2.5.2-alpha.1 : [fix] - Remove unnecessary WC module that was causing issues in usage of module Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants