Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capsule - 2.0.1-alpha.3 - Fix issues with react-jsx runtime by editing vite.config.js #2022

Merged
merged 19 commits into from
Dec 19, 2023

Conversation

vr2amesh
Copy link
Contributor

@vr2amesh vr2amesh commented Dec 8, 2023

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Copy link

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@vitejs/plugin-react 4.2.1 None +12 5.08 MB vitebot
@usecapsule/web-sdk 0.29.4-dev.15...0.29.4 None +1/-1 1.02 MB vtig2020
@types/react 18.2.39...18.2.42 None +0/-0 365 kB types

@@ -25,7 +26,8 @@ const config = {
}
},
define: {
'import.meta.env.VERCEL': JSON.stringify(process.env.VERCEL)
'import.meta.env.VERCEL': JSON.stringify(process.env.VERCEL),
'process.env.NODE_DEBUG': JSON.stringify('')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we do. Otherwise errors are being thrown that it doesn't see it in env

@Adamj1232 Adamj1232 merged commit 0c0a1c3 into blocknative:develop Dec 19, 2023
3 checks passed
@Adamj1232 Adamj1232 changed the title Fix issues with react-jsx runtime by editing vite.config.js Capsule - 2.0.1-alpha.3 - Fix issues with react-jsx runtime by editing vite.config.js Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants