Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the connect modal getting covered by the bottom bar #2057

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Fix the connect modal getting covered by the bottom bar #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
867b532
fix the connect modal being covered by the bottom bar
mhughdo Jan 24, 2024
3cb2d4b
pump the package version
mhughdo Jan 24, 2024
ab4b39b
Merge branch 'develop' into fix/connect-modal-covered-by-bottom-bar
mhughdo Feb 3, 2024
a313dcb
Merge branch 'develop' into fix/connect-modal-covered-by-bottom-bar
Adamj1232 Feb 5, 2024
206d6cc
feat: remove .mobile-safari class
mhughdo Feb 7, 2024
9b4bee0
bump packages' version
mhughdo Feb 18, 2024
2a0dcb6
Merge branch 'develop' into fix/connect-modal-covered-by-bottom-bar
Adamj1232 Feb 20, 2024
fc3c831
bump the version of @web3-onboard/core in other packages
mhughdo Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/core",
"version": "2.21.2",
"version": "2.21.3-alpha.1",
"description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"keywords": [
"Ethereum",
Expand Down
11 changes: 1 addition & 10 deletions packages/core/src/views/connect/Index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,6 @@
scrollContainer && scrollContainer.scrollTo(0, 0)
}

const isSafariMobile =
device.type === 'mobile' &&
device.browser.name &&
device.browser.name === 'Safari'
</script>

<style>
Expand Down Expand Up @@ -532,11 +528,6 @@
.scroll-container::-webkit-scrollbar {
display: none; /* Chrome, Safari and Opera */
}
.mobile-safari {
/* Handles for Mobile Safari's floating Address Bar
covering the bottom of the connect modal **/
padding-bottom: 80px;
}

@media all and (min-width: 768px) {
.container {
Expand All @@ -560,7 +551,7 @@

{#if !autoSelect.disableModals}
<Modal close={!connect.disableClose && close}>
<div class="container" class:mobile-safari={isSafariMobile}>
<div class="container">
{#if connect.showSidebar}
<Sidebar step={$modalStep$} />
{/if}
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/views/shared/Modal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
.full-screen-background {
width: 100vw;
height: 100vh;
height: 100dvh;
}

.max-height {
Expand Down
4 changes: 2 additions & 2 deletions packages/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "demo",
"version": "2.0.9",
"version": "2.0.10",
"devDependencies": {
"assert": "^2.0.0",
"browserify-zlib": "^0.2.0",
Expand Down Expand Up @@ -33,7 +33,7 @@
"@web3-onboard/capsule": "2.0.1",
"@web3-onboard/cede-store": "^2.2.0",
"@web3-onboard/coinbase": "^2.2.6",
"@web3-onboard/core": "^2.21.2",
"@web3-onboard/core": "^2.21.3-alpha.1",
"@web3-onboard/dcent": "^2.2.7",
"@web3-onboard/enkrypt": "^2.0.3",
"@web3-onboard/fortmatic": "^2.0.18",
Expand Down
4 changes: 2 additions & 2 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/react",
"version": "2.8.13",
"version": "2.8.14-alpha.1",
Adamj1232 marked this conversation as resolved.
Show resolved Hide resolved
"description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"keywords": [
"Ethereum",
Expand Down Expand Up @@ -62,7 +62,7 @@
},
"dependencies": {
"@web3-onboard/common": "^2.3.3",
"@web3-onboard/core": "^2.21.2",
"@web3-onboard/core": "^2.21.3-alpha.1",
"use-sync-external-store": "1.0.0"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/solid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/solid",
"version": "2.0.0",
"version": "2.0.1-alpha.1",
Adamj1232 marked this conversation as resolved.
Show resolved Hide resolved
"description": "A collection of solid Composables for integrating Web3-Onboard in to a Solid project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"keywords": [
"Ethereum",
Expand Down Expand Up @@ -63,7 +63,7 @@
},
"dependencies": {
"@web3-onboard/common": "^2.3.3",
"@web3-onboard/core": "^2.21.0",
"@web3-onboard/core": "^2.21.3-alpha.1",
"solid-js": "^1.8.1"
}
}
4 changes: 2 additions & 2 deletions packages/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@web3-onboard/vue",
"version": "2.7.12",
"version": "2.7.13-alpha.1",
Adamj1232 marked this conversation as resolved.
Show resolved Hide resolved
"description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
"keywords": [
"Ethereum",
Expand Down Expand Up @@ -62,7 +62,7 @@
"@vueuse/core": "^8.4.2",
"@vueuse/rxjs": "^8.2.0",
"@web3-onboard/common": "^2.3.3",
"@web3-onboard/core": "^2.21.2",
"@web3-onboard/core": "^2.21.3-alpha.1",
"vue-demi": "^0.12.4"
},
"peerDependencies": {
Expand Down
Loading