Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Capsule modalProps type #2194

Merged
merged 3 commits into from
May 21, 2024

Conversation

jlm0
Copy link
Contributor

@jlm0 jlm0 commented May 14, 2024

Add new type that Omits isOpen and capsule keys from CapsuleModalV2Props inline with the wagmi v1 and v2 changes made to omit the same keys from CapsuleModalProps.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Add new type that Omits `isOpen` and `capsule` keys from `CapsuleModalV2Props` inline with the wagmi v1 and v2 changes made to omit the same keys from `CapsuleModalProps`.
docs/package.json Outdated Show resolved Hide resolved
Introduces new label type for the CapsuleInitOptions allowing for override of the default labe/icon for client customization.
Copy link

socket-security bot commented May 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@algolia/client-search@4.17.0 None +5 258 kB shortcuts
npm/@babel/code-frame@7.23.5 None 0 23.3 kB nicolo-ribaudo
npm/@babel/compat-data@7.23.5 None 0 64.6 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6 None 0 52 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.23.4 None 0 31.6 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5 None 0 11.7 kB nicolo-ribaudo
npm/@babel/highlight@7.23.4 None 0 18.4 kB nicolo-ribaudo
npm/@babel/parser@7.23.6 None 0 1.89 MB nicolo-ribaudo
npm/@babel/runtime@7.23.2 None 0 247 kB nicolo-ribaudo
npm/@babel/types@7.23.6 environment 0 2.41 MB nicolo-ribaudo
npm/@cosmjs/amino@0.29.5 None +1 227 kB webmaster128
npm/@cosmjs/crypto@0.29.4 None 0 139 kB webmaster128
npm/@cosmjs/encoding@0.29.5 None 0 24.6 kB webmaster128
npm/@cosmjs/math@0.29.5 None 0 36.8 kB webmaster128
npm/@cosmjs/proto-signing@0.29.5 None 0 80 kB webmaster128
npm/@cosmjs/stream@0.29.5 None 0 30.4 kB webmaster128
npm/@cosmjs/tendermint-rpc@0.29.5 network Transitive: environment +3 744 kB webmaster128
npm/@cosmjs/utils@0.29.5 None 0 14.5 kB webmaster128
npm/@docsearch/css@3.3.4 None 0 27.9 kB shortcuts
npm/@docsearch/js@3.3.4 Transitive: environment +4 2.12 MB shortcuts
npm/@ethereumjs/common@2.6.5 None 0 2.53 MB holgerd77
npm/@ethereumjs/tx@3.5.2 None 0 431 kB holgerd77
npm/@iconify-json/ri@1.1.8 None 0 859 kB cyberalien
npm/@iconify/types@2.0.0 None 0 25.7 kB cyberalien
npm/@jridgewell/trace-mapping@0.3.18 None +2 259 kB jridgewell
npm/@metamask/sdk-communication-layer@0.20.2 environment 0 3.04 MB metamaskbot
npm/@metamask/sdk-install-modal-web@0.20.2 None 0 548 kB metamaskbot
npm/@metamask/sdk@0.20.3 Transitive: network +13 34.3 MB metamaskbot
npm/@ngraveio/bc-ur@1.1.6 None +1 138 kB antwnic4
npm/@noble/curves@1.2.0 None 0 1.35 MB paulmillr
npm/@noble/hashes@1.3.2 None 0 747 kB paulmillr
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@safe-global/safe-apps-provider@0.18.0 None 0 33 kB dasanra
npm/@safe-global/safe-apps-sdk@8.1.0 None +1 242 kB dasanra
npm/@scure/base@1.1.6 None 0 80.4 kB paulmillr
npm/@shapeshiftoss/hdwallet-core@1.49.0 None +3 11.6 MB shapeshift-ci-bot
npm/@solana/web3.js@1.87.1 environment, eval, network +1 11.4 MB buffalojoec
npm/@sveltejs/adapter-static@2.0.2 environment 0 8.21 kB svelte-admin
npm/@sveltejs/kit@1.27.2 environment, eval +2 810 kB svelte-admin
npm/@svelteness/kit-docs@1.1.5 Transitive: filesystem, network +2 17 MB mihar-22
npm/@tailwindcss/typography@0.5.9 None 0 86.7 kB bradlc
npm/@toruslabs/base-controllers@2.9.0 network +3 9.29 MB chaitanyapotti
npm/@toruslabs/eccrypto@2.2.1 None 0 47.9 kB chaitanyapotti
npm/@toruslabs/openlogin-jrpc@4.7.2 Transitive: environment +6 2.39 MB chaitanyapotti

🚮 Removed packages: npm/0xsequence@0.43.1, npm/@0xpass/models@2.0.0, npm/@0xpass/passport-viem@2.0.1, npm/@0xpass/passport@2.1.1, npm/@0xpass/webauthn-signer@2.0.0, npm/@adraffy/ens-normalize@1.10.1, npm/@babel/code-frame@7.12.11, npm/@babel/compat-data@7.17.0, npm/@babel/core@7.23.2, npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-create-class-features-plugin@7.22.15, npm/@babel/helper-define-polyfill-provider@0.3.1, npm/@babel/helper-plugin-utils@7.16.7, npm/@babel/helper-validator-option@7.22.15, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/plugin-syntax-typescript@7.22.5, npm/@babel/plugin-transform-modules-commonjs@7.23.0, npm/@babel/plugin-transform-runtime@7.17.0, npm/@babel/plugin-transform-typescript@7.22.15, npm/@babel/preset-typescript@7.23.2, npm/@babel/runtime@7.16.7, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@blocto/dappauth@2.1.0, npm/@blocto/sdk@0.9.1, npm/@chainsafe/as-sha256@0.3.1, npm/@chainsafe/persistent-merkle-tree@0.4.2, npm/@chainsafe/ssz@0.9.4, npm/@coinbase/wallet-sdk@3.9.1, npm/@cspotcode/source-map-consumer@0.8.0, npm/@cspotcode/source-map-support@0.7.0, npm/@discoveryjs/json-ext@0.5.6, npm/@emotion/serialize@1.1.2, npm/@eslint/eslintrc@0.4.3, npm/@ethereumjs/common@2.5.0, npm/@ethereumjs/tx@3.3.2, npm/@ethereumjs/util@8.0.6, npm/@ethersproject/abi@5.7.0, npm/@ethersproject/abstract-provider@5.7.0, npm/@ethersproject/abstract-signer@5.7.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/base64@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/constants@5.7.0, npm/@ethersproject/hash@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/networks@5.7.1, npm/@ethersproject/properties@5.7.0, npm/@ethersproject/rlp@5.7.0, npm/@ethersproject/signing-key@5.7.0, npm/@ethersproject/strings@5.7.0, npm/@ethersproject/transactions@5.7.0, npm/@ethersproject/web@5.7.1, npm/@formatjs/ecma402-abstract@1.11.3, npm/@formatjs/icu-messageformat-parser@2.0.18, npm/@humanwhocodes/config-array@0.5.0, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.19, npm/@keepkey/device-protocol@7.7.0, npm/@lit-labs/ssr-dom-shim@1.1.0, npm/@magic-sdk/commons@4.1.0, npm/@magic-sdk/provider@28.0.2, npm/@magic-sdk/types@24.0.1, npm/@metamask/sdk-communication-layer@0.14.3, npm/@metamask/sdk-install-modal-web@0.14.1, npm/@metamask/sdk@0.14.3, npm/@web3-onboard/coinbase@2.2.7, npm/@web3-onboard/injected-wallets@2.10.16, npm/@web3-onboard/walletconnect@2.5.5, npm/css-loader@6.11.0, npm/style-loader@3.3.4, npm/webpack-cli@5.1.4, npm/webpack-dev-server@4.15.2

View full report↗︎

@jlm0 jlm0 requested a review from Adamj1232 May 20, 2024 13:16
@jlm0
Copy link
Contributor Author

jlm0 commented May 20, 2024

@Adamj1232 Made the package version changes. We also decided on making an additional prop Type change for our module. Thanks!

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/keccak@1.4.0
  • Install script: install
  • Source: npm run rebuild || echo "Keccak bindings compilation fail. Pure JS implementation will be used."
  • orphan: npm/keccak@1.4.0
Install scripts npm/@sveltejs/kit@1.27.2
  • Install script: postinstall
  • Source: node postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/keccak@1.4.0
  • @SocketSecurity ignore npm/@sveltejs/kit@1.27.2

@Adamj1232 Adamj1232 merged commit 1566599 into blocknative:develop May 21, 2024
2 of 3 checks passed
@jlm0 jlm0 deleted the CPSL-1578-Update-Prop-Type branch June 5, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants