Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integrate web3auth in demo app #2233

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

bengobeil
Copy link
Contributor

@bengobeil bengobeil commented Jun 14, 2024

Description

As per previously discussed, integrate new web3auth package in demo app. I added React as a dependency, since demo it is executed as opposed to being a package, wouldn't work otherwise.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

(cherry picked from commit 83885db)
@bengobeil
Copy link
Contributor Author

image
image

@bengobeil bengobeil marked this pull request as draft June 14, 2024 14:34
@bengobeil bengobeil marked this pull request as ready for review June 14, 2024 15:00
@bengobeil
Copy link
Contributor Author

@Adamj1232 ready for review

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I updated the docs to reflect the new init options. Thanks again!

@Adamj1232 Adamj1232 merged commit 26e9991 into blocknative:develop Jun 14, 2024
3 checks passed
@bengobeil
Copy link
Contributor Author

Hey @Adamj1232, it seems as though calling setChain on the useSetChain hook when connected to web3auth wallet does not update the provider in the useConnectWallet hook. I'm not familiar with the codebase enough to fix this, I've been taking a look at day and it seems as though web3auth is not integrate with the rx/js based state, not sure about this. Would it be possible to take a look and point me in the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants