[FIX] : CORE - Handling of empty localStorage item, remove default of empty string and perform a falsey check #2236
Conversation
…ng and perform a falsey check
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
…ion, add try to disconnect logic
Description
Handling of empty localStorage item, remove default of empty string and perform a falsey check.
Ensure that if an empty
connectconfig object is passed and the user doesnt have a localStorage wallet set as the last used then handle check for the last connected wallet properly.Also properly handles empty object passed in through
connect({})Closes: #2227
Closes: #2237
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsTests with demo app (injected)