Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - Gnosis docs : note about browser extension for handling CORS #2258

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Update - Gnosis docs : note about browser extension for handling CORS #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98d1b44
Update docs for gnosis/safe package for building within vue env
Adamj1232 Jul 15, 2024
e4c8fd9
Add clarity and remoinder for peerDeps
Adamj1232 Jul 15, 2024
0745a56
Add cors blocking extension notes
Adamj1232 Jul 15, 2024
11c6907
Add note about cors browser extensions
Adamj1232 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/src/routes/docs/[...4]wallets/[...12]gnosis/+page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ Note: With the `safeTxGas` you will see additional value on the `gasLimit` displ

## Build Environments

For build env configurations and setups please see the Build Env section [here](/docs/modules/core#build-environments)
For build env configurations and setups please see the Build Env section [here](/docs/modules/core#build-environments).


## Local testing within the Safe app

Ensure the application is building and working properly within the browser and then add or enable your cors blocker extension or script of choice. An example is the `Allow CORS` browser extension.

## Vue Build Configuration

Expand Down
4 changes: 4 additions & 0 deletions packages/gnosis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ let trans = await wallet.instance.txs.send({txs:[tx], params})
Note: With the `safeTxGas` you will see additional value on the `gasLimit` displayed in the Safe. Check [Safe docs](https://github.com/safe-global/safe-contracts/blob/a6504a9afdeac186a8cdb29ad68b189523c80eda/docs/safe_tx_gas.md) for full details on that computation.


## Local testing within the Safe app

Ensure the application is building and working properly within the browser and then add or enable your cors blocker extension or script of choice. An example is the `Allow CORS` browser extension.

## Vue Build Configuration

If using Vue be sure to include the necessary peerDeps in the `vite.config.ts` specifically within the `optimizeDeps.include` list and install the necessary peer deps `npm i @safe-global/safe-apps-provider @safe-global/safe-apps-sdk`.
Expand Down
Loading