Merge pull request #510 from blocknetdx/4.3.1

Blocknet Comet v4.3.1

.travis/lint_04_install.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 #
-# Copyright (c) 2018 The Bitcoin Core developers
+# Copyright (c) 2018-2019 The Bitcoin Core developers
 # Distributed under the MIT software license, see the accompanying
 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -10,6 +10,6 @@ travis_retry pip install codespell==1.13.0
 travis_retry pip install flake8==3.5.0
 travis_retry pip install vulture==0.29
 
-SHELLCHECK_VERSION=v0.6.0
-curl -s "https://storage.googleapis.com/shellcheck/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/
-export PATH="/tmp/shellcheck-${SHELLCHECK_VERSION}:${PATH}"
+SHELLCHECK_VERSION=v0.7.1
+curl -sL "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/
+export PATH="/tmp/shellcheck-${SHELLCHECK_VERSION}:${PATH}"

configure.ac

@@ -2,7 +2,7 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
 AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 4)
 define(_CLIENT_VERSION_MINOR, 3)
-define(_CLIENT_VERSION_REVISION, 0)
+define(_CLIENT_VERSION_REVISION, 1)
 define(_CLIENT_VERSION_BUILD, 0)
 define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)

doc/release-notes/release-notes-4.3.1.md

@@ -0,0 +1,48 @@
+# Blocknet Comet 4.3.1 Release Notes
+
+Notable changes
+================
+
+- Improved partial orders support
+- dxPartialOrderChainDetails rpc call
+- dxGetMyPartialOrderChain rpc call
+- Fixed order cancellation issues
+- Coin Control tree view
+- Coin Control keyboard navigation added 
+- New Balances screen
+- Address book improvements
+- Dashboard transaction list fixes
+- Support lowercase rpc calls
+
+Changelog
+================
+
+- 6af51a592 4.3.1 release
+- b6d2e5ceb [xbridge] improved order amount checks
+- 9b5b49446 [xbridge] version bump 55
+- 974e9d638 [xbridge] partial orders drift check on amounts
+- 6804d82bf [xbridge] fix dxPartialOrderChainDetails
+- dad60112f [xbridge] use ints in partial order price checks
+- 21fd33a0b [xbridge] use correct conversion to xbridge float
+- f3169f0e5 Update partial order data help msgs
+- 96cf3b6a8 [xbridge] fix partial orders utxo selector
+- d7f31014f [xbridge] log partial prep tx
+- 4918db724 [core] support case insensitive rpc calls
+- 73d7977d6 [xbridge] partial order improvements
+- 6d6015978 [core] shellcheck linter update to v0.7.1
+- e7199f8cb [gui] fix dashboard table issues
+- e4de38e61 [gui] fix duplicate addresses on create
+- 651129099 [gui] addressbook create new address title
+- 753eb1b07 [gui] show proper address entry on double-click
+- d3c636a0a [gui] fix rescan after privkey import
+- a7a2e2509 [gui] add blocknet balances page; improve addressbook table
+- 38928f64d [gui] display warning on bad pubkey import; fix private key import
+- 726873367 [gui] improved coin control tree selection states; context menu fixes
+- 33e3d6f84 [xbridge] fix order cancel when order is not mine
+- 093003a47 [gui] set table focus on mode switch
+- feb31f047 [gui] refactor coin control state mgmt
+- fdec95670 [gui] add coin control keyboard navigation
+- 4d4b85186 [core] adjust timing of client loading progress
+- 768910060 [gui] fix disappearing address label
+- 43a417b8d [gui] added coin control tree view to redesign
+- 0e5953e7d 4.3.1

src/Makefile.qt.include

@@ -170,6 +170,7 @@ QT_MOC_CPP += \
 if ENABLE_WALLET
 QT_MOC_CPP += \
   qt/moc_blocknetactionbtn.cpp \
+  qt/moc_blocknetaccounts.cpp \
   qt/moc_blocknetaddressbook.cpp \
   qt/moc_blocknetaddressbtn.cpp \
   qt/moc_blocknetaddressedit.cpp \
@@ -313,6 +314,7 @@ BITCOIN_QT_H = \
 # Blocknet Qt files
 BITCOIN_QT_H += \
   qt/blocknetactionbtn.h \
+  qt/blocknetaccounts.h \
   qt/blocknetaddressbook.h \
   qt/blocknetaddressbtn.h \
   qt/blocknetaddressedit.h \
@@ -458,6 +460,8 @@ RES_ICONS += \
   qt/res/redesign/icons/block-icon.png \
   qt/res/redesign/icons/checkmark-off.png \
   qt/res/redesign/icons/checkmark-on.png \
+  qt/res/redesign/icons/checkmark-partial.png \
+  qt/res/redesign/icons/lock_closed_white.png \
   qt/res/redesign/icons/NavBarIcons/Active/AddressBookIcon.png \
   qt/res/redesign/icons/NavBarIcons/Active/AnnouncementsIcon.png \
   qt/res/redesign/icons/NavBarIcons/Active/DashboardIcon.png \
@@ -552,6 +556,7 @@ BITCOIN_QT_WALLET_CPP = \
 # Blocknet wallet files
 BITCOIN_QT_WALLET_CPP += \
   qt/blocknetactionbtn.cpp \
+  qt/blocknetaccounts.cpp \
   qt/blocknetaddressbook.cpp \
   qt/blocknetaddressbtn.cpp \
   qt/blocknetaddressedit.cpp \

src/Makefile.test.include

@@ -136,6 +136,10 @@ BITCOIN_TESTS += \
 BITCOIN_TEST_SUITE += \
   test/xrouter_tests.h
 
+# Blocknet XBridge
+BITCOIN_TESTS += \
+  test/xbridge_tests.cpp
+
 if ENABLE_PROPERTY_TESTS
 BITCOIN_TESTS += \
   test/key_properties.cpp

src/qt/bitcoin.qrc

@@ -128,6 +128,8 @@
         <file alias="HeaderViewArrowDown">res/redesign/icons/Table/HeaderViewArrowDown.png</file>
         <file alias="checkmark-on">res/redesign/icons/checkmark-on.png</file>
         <file alias="checkmark-off">res/redesign/icons/checkmark-off.png</file>
+        <file alias="checkmark-partial">res/redesign/icons/checkmark-partial.png</file>
+        <file alias="lock_closed_white">res/redesign/icons/lock_closed_white.png</file>
         <file alias="block-icon">res/redesign/icons/block-icon.png</file>
         <file alias="Roboto-Black.ttf">res/redesign/fonts/Roboto/Roboto-Black.ttf</file>
         <file alias="Roboto-BlackItalic.ttf">res/redesign/fonts/Roboto/Roboto-BlackItalic.ttf</file>