feat(env-collector): a few improvements for using in stats #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bragov4ik
commented
Sep 2, 2024
•
bragov4ik
commented
- configurable anchor postfix
- more flexible filtering
- keep user-defined order in the table
- ignore non-ascii symbols in env names (to allow custom formatting with zero-width spaces, for example)
- more compact "Required" column
- more general allowed format for "default value" column
bragov4ik
force-pushed
the
bragov4ik/env-collector-configure-anchors
branch
2 times, most recently
from
a4ff7c3
to
add668d
Compare
Base automatically changed from
bragov4ik/env-collector-test-case
to
ll/env-collector
September 3, 2024 09:45
bragov4ik
force-pushed
the
bragov4ik/env-collector-configure-anchors
branch
from
add668d
to
9c732d7
Compare
bragov4ik
changed the title
env-collectorenv-collector
sevenzing
reviewed
Sep 7, 2024
sevenzing
reviewed
Sep 7, 2024
sevenzing
approved these changes
Sep 7, 2024
sevenzing
reviewed
Sep 7, 2024
bragov4ik
changed the title
env-collector…ero-width space or other formatting
bragov4ik
force-pushed
the
bragov4ik/env-collector-configure-anchors
branch
from
1580ed1
to
16f2ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.