Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of github actions (+ test fix) #825

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

bragov4ik
Copy link
Contributor

There are some warnings in CI that should be fixed by bumping actions versions.
example:
https://github.com/blockscout/blockscout-rs/actions/runs/8560946122/job/23461168368?pr=823#step:8:23

the update should be trivial as the updated actions have barely any options and seem to do elementary stuff

@bragov4ik bragov4ik force-pushed the kirillivanov/update-workflows branch from 45c187d to 2541e0a Compare April 8, 2024 13:32
@bragov4ik bragov4ik changed the title Update versions of github actions Update versions of github actions (+ test fix) Apr 8, 2024
Copy link
Member

@rimrakhimov rimrakhimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

Just interested, maybe you know the way to extract common workflow steps into a separate workflow which can be reused further? So, that such changes can be made only in the original workflow file in the future

@bragov4ik
Copy link
Contributor Author

maybe you know the way to extract common workflow steps into a separate workflow which can be reused further?

AFAIR this is what we need:
https://docs.github.com/en/actions/using-workflows/reusing-workflows

sounds good, we should do it some time 👀

@rimrakhimov
Copy link
Member

Let's merge this PR, and then check if we can apply reusable workflows to our setup when we have time

@rimrakhimov rimrakhimov merged commit 39179f8 into main Apr 11, 2024
35 checks passed
@rimrakhimov rimrakhimov deleted the kirillivanov/update-workflows branch April 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants