-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Workaround for repeating logIndex #10880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitosing
requested review from
vbaranov,
varasev,
fedor-ivn,
sl1depengwyn,
Qwerty5Uiop and
k1rill-fedoseev
October 16, 2024 13:45
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Show resolved
Hide resolved
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Show resolved
Hide resolved
vbaranov
reviewed
Oct 17, 2024
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Outdated
Show resolved
Hide resolved
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Outdated
Show resolved
Hide resolved
fedor-ivn
reviewed
Oct 18, 2024
apps/explorer/lib/explorer/migrator/sanitize_duplicated_log_index_logs.ex
Outdated
Show resolved
Hide resolved
nikitosing
force-pushed
the
np-workaround-for-not-unique-log-index
branch
from
October 19, 2024 20:32
7f7d9f4
to
1387a5e
Compare
vbaranov
approved these changes
Oct 21, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sometimes different ETH JSON RPC clients returns bugged response with duplicated logIndex within block or even transaction.
Changelog
Checklist for your Pull Request (PR)
master
in the Version column. If I removed variable, I added it to Deprecated ENV Variables page. After merging docs PR, changes will be reflected in these pages.