Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround for repeating logIndex #10880

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Oct 4, 2024

Motivation

sometimes different ETH JSON RPC clients returns bugged response with duplicated logIndex within block or even transaction.

Changelog

  • Set new LogIndexes if logIndex is not unique within a block
  • Create a migration in order to apply fix to already imported logs, token transfers and token instances

Checklist for your Pull Request (PR)

  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so by submitting a PR to docs repository.
  • If I added/changed/removed ENV var, I submitted a PR to docs repository to update the list of env vars and I updated the version to master in the Version column. If I removed variable, I added it to Deprecated ENV Variables page. After merging docs PR, changes will be reflected in these pages.
  • If I added new DB indices, I checked, that they are not redundant, with PGHero or other tools.
  • If I added/removed chain type, I modified the Github CI matrix and PR labels accordingly.

@nikitosing nikitosing force-pushed the np-workaround-for-not-unique-log-index branch from 7f7d9f4 to 1387a5e Compare October 19, 2024 20:32
@vbaranov vbaranov merged commit 213a324 into master Oct 22, 2024
16 checks passed
@vbaranov vbaranov deleted the np-workaround-for-not-unique-log-index branch October 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants