Refine contributing procedure #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
goodsoft
approved these changes
Mar 15, 2019
Pull Request Test Coverage Report for Build b028a5a4-c5bc-451e-b853-c40aeeb80476
💛 - Coveralls |
zachdaniel
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to collect all updates into the release. It is hard to collect them at one time, keeping in mind that release can contain tens of PRs. To be sure that all updates are added to the release, it is suggested to update
CHANGELOG.mdwith the description of update and the link to PR for each contribution.Changelog
CHANGELOG.mdis added with the description of1.3.5release.CONTRIBUTING.md, where contributor should updateCHANGELOG.mdwith every PR.