Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new function clause for uncle errors #2128

Merged
merged 6 commits into from
Jun 11, 2019
Merged

add new function clause for uncle errors #2128

merged 6 commits into from
Jun 11, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #2126 (comment)

Changelog

  • add new function clause for uncle errors

@ayrat555 ayrat555 mentioned this pull request Jun 10, 2019
Closed
vbaranov
vbaranov approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 👍 please add CHANGELOG entry

@coveralls
Copy link

coveralls commented Jun 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build b6e8d218-c377-450d-9e79-1261b6c36f12

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 80.715%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/fetcher/uncle_block.ex 1 3 33.33%
Totals Coverage Status
Change from base Build c737b89a-9980-4fbd-8b2e-285d1b3edf96: 0.09%
Covered Lines: 4901
Relevant Lines: 6072
💛 - Coveralls

@vbaranov vbaranov merged commit c4970d4 into master Jun 11, 2019
@vbaranov vbaranov deleted the ab-fix-error-message-for-uncles branch June 11, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"fetcher=block_uncle count=10" Error
6 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @saneery @pasqu4le