-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show all token transfers #2190
Merged
Merged
show all token transfers #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4629562d-fa54-4731-b88e-dc19f2fb62f8
💛 - Coveralls |
pasqu4le
approved these changes
Jun 19, 2019
saneery
approved these changes
Jun 24, 2019
vbaranov
reviewed
Jun 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is a big space between transfer values
/tx/0x137acc29647ec5bb0dd03d33779ca34501541f05b83a18a35ac93edaf0f963c5/token_transfers
- Why are token transfers not recognized in this tx?
/tx/0x6d31e77f60baec0c3d54e569b8e9bda6f31c91272cbf1e82324843a5355bcbd4/token_transfers
|
@vbaranov I addressed your comment about spaces |
@ayrat555 please attach the screenshot of the summary block after the fix. |
@vbaranov done |
vbaranov
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1792
Motivation
Token Transfer
title for transactions for which we couldn't identify a type0xbeea8c6b013cd052c8ef9e3650c86157d4e502f0fa78c6320e4366670b6b798a
which have their tokens split into multiple internal transactionsChangelog