-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return gasPrice at gettxinfo API's method #2403
Conversation
Pull Request Test Coverage Report for Build 0a74354c-01f8-4786-bbe8-51d7c5cba9e2
💛 - Coveralls |
Please add json schema test so we won't lose anything in the future |
@ayrat555 what the schema? where can I find an example? |
@saneery https://en.wikipedia.org/wiki/JSON#JSON_Schema we didn't test JSON schema yet but I think it's time to start. this PR is a good opportunity https://github.com/jonasschmidt/ex_json_schema |
@saneery are you going to resolve my comment? I didn't get an answer in 2 weeks |
@ayrat555 maybe it should be different PR since we need to add a new dependency? |
#2348
Motivation
Add
gasPrice
field at the result ofgettinfo
methodCHANGELOG.md
with this PR