-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send events through postgres notify #2449
Conversation
77cd8f3
to
e6df337
Compare
Pull Request Test Coverage Report for Build 3bb441bb-ca24-467d-a26e-7e2f2216da9f
💛 - Coveralls |
89bef55
to
cc0f237
Compare
cc0f237
to
19d84ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please update the corresponding chapter with the new env vars
- please add those env var(s) to the description of PR
- can we make sending events through postgres notify configurable via env var and if it is not set - use the current websocket architecture?
I didn't add new vars
Yes, I think it's possible |
Ah, indeed, sorry. I mistakenly thought, that |
Hi! Is there any plan to merge/review this PR? I have been using Blockscout from this commit and so far so good. |
I have been testing this PR and I think it breaks the option to configure the database with the env variable
Configuration using config files work well. |
@jcortejoso I'll finish this. Thanks for testing |
@ayrat555 thanks. I added this to
Best! |
this kind of variables should be configured with |
@ayrat555 there is no changelog entry |
#2354
Realtime events are sending by Registry, but when indexer runs separately from webapp, on different instances, events aren't delivered.
So I updated publisher to send events through Postgres notification and added
Listener
that listen to events from Postgres and send them to subscribed processesTo test you can run indexer and webapp separately and make sure that realtime updates are delivered in the main page.