Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix first page button for uncles and reorgs #2564

Merged
merged 9 commits into from
Aug 14, 2019
Merged

fix first page button for uncles and reorgs #2564

merged 9 commits into from
Aug 14, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 13, 2019 •
edited
Loading

fixes #2556

Changelog

  • fix the first-page button for uncles and reorgs

@ayrat555 ayrat555 changed the title fix first page button for uncles and rewards fix first page button for uncles and reorgs Aug 13, 2019
vbaranov
vbaranov approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 Approved with one minor comment

apps/block_scout_web/assets/js/lib/async_listing_load.js Outdated Show resolved Hide resolved
pasqu4le
pasqu4le approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little thing

CHANGELOG.md Outdated Show resolved Hide resolved
saneery
saneery approved these changes Aug 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit 3328543 into master Aug 14, 2019
@vbaranov vbaranov deleted the ab-fix-first-page-for-uncles-and-reorgs branch August 14, 2019 11:27
@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 56a8f90a-850b-4e10-bc0d-9535dc9b5225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.326%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 42ff2d9d-34c5-4b5e-8a93-a1f1c48cd8b7: -0.03%
Covered Lines: 5203
Relevant Lines: 6559
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination first button on blocks (uncles) page doesn't work
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le