Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix library verification #2731

Merged
merged 3 commits into from
Sep 26, 2019
Merged

fix library verification #2731

merged 3 commits into from
Sep 26, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #2727

Motivation

bytecode of a library contains the address of a deployed library

Changelog

  • fix library verification

bytecode of a library contains address of a deployed library
@coveralls
Copy link

coveralls commented Sep 24, 2019

Pull Request Test Coverage Report for Build dc9593a1-bba2-4e78-a3c7-7ff8f4fe80db

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 78.585%

Totals Coverage Status
Change from base Build 37c8d465-d605-4c7e-85ae-2b97e4e45c71: 0.1%
Covered Lines: 5266
Relevant Lines: 6701

💛 - Coveralls

@@ -81,6 +82,17 @@ defmodule Explorer.SmartContract.Verifier do
end
end

defp try_library_verification(
"730000000000000000000000000000000000000000" <> bytecode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 what is 730000000000000000000000000000000000000000 ? Let's add a comment on function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @vbaranov

@vbaranov vbaranov merged commit c5d9329 into master Sep 26, 2019
@vbaranov vbaranov deleted the ab-fix-library-compilation branch September 26, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library verification doesn't work
4 participants