Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eth_blockNumber API endpoint to eth_rpc section #2859

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 14, 2019

Closes #2586

Motivation

Changelog

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Nov 14, 2019
@vbaranov vbaranov added the wip label Nov 14, 2019
@vbaranov vbaranov force-pushed the vb-move-eth-block-number-api-endpoint branch from d417f13 to 37000c1 Compare November 14, 2019 13:17
@vbaranov vbaranov force-pushed the vb-move-eth-block-number-api-endpoint branch from 37000c1 to 28acc6d Compare November 14, 2019 13:21
@coveralls
Copy link

coveralls commented Nov 14, 2019

Pull Request Test Coverage Report for Build c57ce4c5-3977-42a4-9291-4146d5a7fb95

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 75.62%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api/rpc/block_view.ex 0 1 0.0%
apps/explorer/lib/explorer/eth_rpc.ex 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/eth_rpc.ex 1 0.0%
Totals Coverage Status
Change from base Build 88d3a922-5da0-4575-ad14-095b7bda0b8b: 0.007%
Covered Lines: 5248
Relevant Lines: 6940

💛 - Coveralls

@vbaranov vbaranov requested a review from ayrat555 November 14, 2019 13:35
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels Nov 14, 2019
@vbaranov vbaranov merged commit 0789ce8 into master Nov 19, 2019
@vbaranov vbaranov deleted the vb-move-eth-block-number-api-endpoint branch November 19, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eth_blockNumber API to ETH RPC
3 participants