-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add block_hash to token_transfers #2872
Merged
vbaranov
merged 15 commits into
pp-pending-block-ops
from
ab-do-not-remove-nonconsensus-token-transfers
Nov 27, 2019
Merged
add block_hash to token_transfers #2872
vbaranov
merged 15 commits into
pp-pending-block-ops
from
ab-do-not-remove-nonconsensus-token-transfers
Nov 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build d78d4d4c-b66a-4667-b6c4-0bb3179d3bf6
💛 - Coveralls |
ayrat555
force-pushed
the
ab-do-not-remove-nonconsensus-token-transfers
branch
from
November 26, 2019 13:06
254fe2f
to
c1bb8da
Compare
ayrat555
force-pushed
the
ab-do-not-remove-nonconsensus-token-transfers
branch
from
November 26, 2019 13:16
c1bb8da
to
9ac231b
Compare
vbaranov
reviewed
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 please fix merging conflicts
…s-token-transfers
vbaranov
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2865
This PR adds block_hash to token_transfers table and adds it to a composite primary key. That's how we can get rid of heavy token_transfers removal operation during blocks import.