Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token instance QR code data when api_path is different from path #3017

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 19, 2020

Motivation

Continuation of #3016

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Feb 19, 2020
@vbaranov vbaranov force-pushed the vb-qr-code-data-fix-2 branch from 7e3826c to 65a63b8 Compare February 19, 2020 21:40
@coveralls
Copy link

coveralls commented Feb 19, 2020

Pull Request Test Coverage Report for Build 428256c4-e3f9-49f4-bdc1-d03c3a3b57e3

  • 6 of 22 (27.27%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 75.266%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api_docs_view.ex 6 8 75.0%
apps/block_scout_web/lib/block_scout_web/views/tokens/instance/overview_view.ex 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_transaction_controller.ex 1 65.0%
Totals Coverage Status
Change from base Build aba031ac-f8d2-4a4b-a62c-c9aacd9cd259: -0.1%
Covered Lines: 5438
Relevant Lines: 7225

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-qr-code-data-fix-2 branch 11 times, most recently from b00b5e7 to 842c845 Compare February 20, 2020 14:58
@vbaranov vbaranov force-pushed the vb-qr-code-data-fix-2 branch from 842c845 to 6ba9fa5 Compare February 20, 2020 15:12
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Feb 20, 2020
@vbaranov vbaranov merged commit f42ef81 into master Feb 20, 2020
@vbaranov vbaranov deleted the vb-qr-code-data-fix-2 branch February 20, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants