Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verification of contracts with error messages in require in parent contract #3061

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 26, 2020

Motivation

Unable to verify contract with an error message in require in the parent contract. Example: https://blockscout.com/poa/sokol/address/0xA4cd10f954Ce31DE5Cf498D9973D0A46Cb53b3d9/transactions

Changelog

Check of occurrences of all require messages from the source code in the rest of bytecode to correctly define encoded constructor arguments

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Find all require messages in the source code Fix verification of contracts with error messages in require in parent contract Mar 26, 2020
@vbaranov vbaranov force-pushed the vb-fix-contract-verification branch 2 times, most recently from 01d903b to 4ec49d7 Compare March 26, 2020 13:03
@coveralls
Copy link

coveralls commented Mar 26, 2020

Pull Request Test Coverage Report for Build 90681ff2-fb43-49a9-9c7f-93a68b7da700

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 74.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 9 78.95%
Totals Coverage Status
Change from base Build 1da0935e-67d2-4a2d-8018-e79a84c3d49c: -0.1%
Covered Lines: 5514
Relevant Lines: 7356

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-fix-contract-verification branch 2 times, most recently from e873f4e to 2b7fc92 Compare March 26, 2020 13:24
@vbaranov vbaranov force-pushed the vb-fix-contract-verification branch from 2b7fc92 to d6a3119 Compare March 26, 2020 14:15
@vbaranov vbaranov merged commit fcb160c into master Mar 26, 2020
@vbaranov vbaranov deleted the vb-fix-contract-verification branch March 26, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants