-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance of coin balance history chart #3125
Merged
vbaranov
merged 8 commits into
master
from
vb-fix-performance-coin-balance-history-nnew-wave
Jun 2, 2020
Merged
Fix performance of coin balance history chart #3125
vbaranov
merged 8 commits into
master
from
vb-fix-performance-coin-balance-history-nnew-wave
Jun 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
from
May 26, 2020 11:05
e0643af
to
c21cdc9
Compare
Pull Request Test Coverage Report for Build e908e697-779e-4dca-a320-c85757576711
💛 - Coveralls |
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
from
May 26, 2020 11:15
c21cdc9
to
3af241b
Compare
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
from
May 26, 2020 11:21
3af241b
to
14fbf27
Compare
…coin-balance-history-nnew-wave
…coin-balance-history-nnew-wave
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
13 times, most recently
from
May 29, 2020 12:31
238b059
to
a69c582
Compare
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
6 times, most recently
from
May 29, 2020 16:32
f0b6d1b
to
bb9e7bd
Compare
@vbaranov if you want to improve the frontend chart performance, too you can try using uPlot instead of Chart.js. Phoenix LiveDashboard uses uPlot for their real-time metrics panel. /shameless plug :D |
@leeoniya performance comparison of chart libraries looks promising! Definitely I should give it a try. Thanks for pointing me out. |
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
3 times, most recently
from
June 1, 2020 11:41
3ca9697
to
e27add4
Compare
vbaranov
force-pushed
the
vb-fix-performance-coin-balance-history-nnew-wave
branch
from
June 1, 2020 11:57
e27add4
to
c669359
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1946
Changelog
Create a proper table to get data for coin balance history chart:
and adding a logic of filling it with the data. Retrieve data for coin balance history chart from this table. After this PR, the number of days to display at the coin balance history chart can be configured via environment variable COIN_BALANCE_HISTORY_DAYS
Related PR to add COIN_BALANCE_HISTORY_DAYS env var to the list blockscout/docs#20
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.