Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write contracts feature #3160

Merged
merged 13 commits into from
Jun 30, 2020
Merged

Write contracts feature #3160

merged 13 commits into from
Jun 30, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jun 22, 2020

Resolves #71
Resolves #72
Resolves #73
Resolves #77
Resolves #80
Resolves #81
Resolves #3170

Motivation

Blockscout doesn't provide the opportunity to send transactions to smart-contracts

Changelog

  • a new tab with write-only functions
  • interaction with MetaMask/Nifty Wallet
  • success/warning/error modal windows (styles are from staking dApp PR Add Web UI for POSDAO Staking DApp #2292)
  • support payable methods
  • enables "Write proxy" feature
  • excludes constructors from write functions list

Screenshot 2020-06-24 at 17 33 48
Screenshot 2020-06-24 at 15 25 29
Screenshot 2020-06-23 at 16 26 24
Screenshot 2020-06-24 at 12 00 06
Screenshot 2020-06-24 at 12 17 46
Screenshot 2020-06-24 at 12 18 10

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Jun 22, 2020

Pull Request Test Coverage Report for Build 1e34a1b2-3b6e-42eb-b479-c001357141b0

  • 56 of 67 (83.58%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.38%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_read_contract_view.ex 1 2 50.0%
apps/block_scout_web/lib/block_scout_web/views/address_read_proxy_view.ex 1 2 50.0%
apps/block_scout_web/lib/block_scout_web/views/address_write_contract_view.ex 2 3 66.67%
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 2 4 50.0%
apps/block_scout_web/lib/block_scout_web/controllers/smart_contract_controller.ex 11 14 78.57%
apps/block_scout_web/lib/block_scout_web/views/address_write_proxy_view.ex 0 3 0.0%
Totals Coverage Status
Change from base Build 3caf8ffc-1bef-4193-8b28-e784217923bb: 0.05%
Covered Lines: 5966
Relevant Lines: 8021

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-write-contracts branch 6 times, most recently from 2724d62 to 7bb9cc1 Compare June 23, 2020 11:17
@vbaranov vbaranov force-pushed the vb-write-contracts branch from 7bb9cc1 to fe78cbf Compare June 24, 2020 08:01
@vbaranov vbaranov force-pushed the vb-write-contracts branch from e992fe9 to 9717502 Compare June 24, 2020 12:48
@vbaranov vbaranov force-pushed the vb-write-contracts branch from aa36e41 to d0ce9e2 Compare June 24, 2020 14:12
@vbaranov vbaranov self-assigned this Jun 24, 2020
@vbaranov vbaranov mentioned this pull request Jun 25, 2020
6 tasks
@vbaranov vbaranov force-pushed the vb-write-contracts branch from a62e234 to 72a7748 Compare June 29, 2020 11:48
@vbaranov vbaranov force-pushed the vb-write-contracts branch from 72a7748 to ed30893 Compare June 29, 2020 13:29
@vbaranov vbaranov force-pushed the vb-write-contracts branch from aa6be21 to 0fe6f55 Compare June 30, 2020 09:42
@vbaranov vbaranov force-pushed the vb-write-contracts branch from 0fe6f55 to 3877fb1 Compare June 30, 2020 10:04
@vbaranov vbaranov merged commit 69fccf5 into master Jun 30, 2020
@vbaranov vbaranov deleted the vb-write-contracts branch June 30, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment