Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1967 support: transparent proxy pattern #3174

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 2, 2020

#3163

Motivation

Blockscout doesn't support retrieving of implementation from storage point defined by EIP-1967

Changelog

  • add eth_getStorageAt call support
  • get implementation from 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc storage pointer of proxy contract if implementation getter has nonpayable stateMutability.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jul 2, 2020
@vbaranov vbaranov changed the title EIP-1967 support EIP-1967 support: transparent proxy pattern Jul 2, 2020
@coveralls
Copy link

coveralls commented Jul 2, 2020

Pull Request Test Coverage Report for Build 3a2ffd42-288f-43ae-b875-d1e303c8e340

  • 15 of 29 (51.72%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 74.257%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/smart_contract_controller.ex 3 4 75.0%
apps/explorer/lib/explorer/chain.ex 9 13 69.23%
apps/explorer/lib/explorer/smart_contract/reader.ex 1 5 20.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/contract.ex 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 9a51de8e-f3ae-459b-ac50-9ce2b62f7c06: -0.1%
Covered Lines: 5968
Relevant Lines: 8037

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-eip1967-transparent-proxy-support branch 2 times, most recently from 8e47b61 to 8eaf347 Compare July 2, 2020 11:18
@vbaranov vbaranov force-pushed the vb-eip1967-transparent-proxy-support branch from 8eaf347 to 5be42bb Compare July 2, 2020 11:31
@vbaranov vbaranov merged commit 672dfd2 into master Jul 2, 2020
@vbaranov vbaranov deleted the vb-eip1967-transparent-proxy-support branch July 2, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants