Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine contract method signature detection for read/write feature #3237

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 13, 2020

Motivation

Internal server error for reading method if ABI consists of multiple methods with the same name

Changelog

Replace function_name with method_id to a better search of the target method to call

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Fix contract function method detection Refine contract method signature detection for read/write feature Aug 13, 2020
@github-actions
Copy link

Pull Request Test Coverage Report for Build 76454ac0ca0873415646c6cc5a8c596c6bb83dc2-PR-3237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.7%) to 55.793%

Totals Coverage Status
Change from base Build a2a32489077a9e82f15b52fa4076128d7824d3a0: -15.7%
Covered Lines: 443
Relevant Lines: 794

💛 - Coveralls

@vbaranov vbaranov merged commit 41ceae9 into master Aug 14, 2020
@vbaranov vbaranov deleted the vb-fix-contract-read-function-detection branch August 14, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant