Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inventory tab pagination #3346

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix inventory tab pagination #3346

merged 1 commit into from
Oct 12, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 12, 2020

Motivation

ERC-721 inventory pages 1+ failed to open

unknown

Changelog

Do not apply checksum to checksummed address for pagination of inventory

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-fix-inventory-pagination branch from c4b4670 to 8a80e62 Compare October 12, 2020 14:26
@coveralls
Copy link

coveralls commented Oct 12, 2020

Pull Request Test Coverage Report for Build 73ace1944a28fc7368aa95d37a1b6cf3b1099d0a-PR-3346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.9%) to 74.389%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/channels/address_channel.ex 2 36.96%
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build c49d0269d32066e7e506c8d65080ccd0e046a3b6: 4.9%
Covered Lines: 1978
Relevant Lines: 2659

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-fix-inventory-pagination branch from 8a80e62 to 73ace19 Compare October 12, 2020 15:30
@vbaranov vbaranov merged commit 2891ef7 into master Oct 12, 2020
@vbaranov vbaranov deleted the vb-fix-inventory-pagination branch October 12, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants