Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve blocks handling in Staking DApp #3443

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Nov 10, 2020

Motivation

This improves blocks handling in the Staking DApp. Now the app can correctly handle possible block gaps and delays both on the client and server sides. Also, it should speed up the server side of the app as it now uses a separate thread for handling the :staking_update message (now it is handled by the StakingEventHandler instead of the RealtimeEventHandler).

These changes relate to #3400 and #3434.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Nov 10, 2020

Pull Request Test Coverage Report for Build 9e5f9040a9adf7aa782904851bacf1ca53221009-PR-3443

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 211 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.9%) to 67.037%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/application.ex 1 83.33%
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
lib/block_scout_web/checksum_address.ex 6 55.56%
lib/block_scout_web/notifier.ex 12 85.06%
lib/block_scout_web/controllers/stakes_controller.ex 20 58.82%
lib/block_scout_web/channels/stakes_channel.ex 171 0%
Totals Coverage Status
Change from base Build 93198f2acc2070fef133d6b8a074d4dc687050b1: -0.9%
Covered Lines: 2050
Relevant Lines: 3058

💛 - Coveralls

@varasev varasev requested a review from vbaranov November 10, 2020 11:37
@varasev varasev force-pushed the va-staking-dapp-enhance-blocks-handling branch from ff1681c to 80fc17d Compare November 12, 2020 08:19
@vbaranov
Copy link
Member

@varasev Looks good in overall, some minor changes are requested in order to increase readability.

@varasev varasev force-pushed the va-staking-dapp-enhance-blocks-handling branch from 5e1ef0b to b1e1e10 Compare November 12, 2020 13:53
@vbaranov vbaranov force-pushed the va-staking-dapp-enhance-blocks-handling branch from b1e1e10 to 9e5f904 Compare November 13, 2020 14:17
@vbaranov vbaranov merged commit 4e520f7 into master Nov 13, 2020
@vbaranov vbaranov deleted the va-staking-dapp-enhance-blocks-handling branch November 13, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants