Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Staking DApp work with transferAndCall function #3498

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Dec 1, 2020

Motivation

I recently updated the StakingAuRa contract so that it supports staking with transferAndCall function along with the stake function. We need this to switch POSDAO from the non-bridged STAKE token contract to the bridged one.

Please, don't merge this until we switch the StakingAuRa contract to the new implementation. I'll let you know when that happens. Done: https://github.com/poanetwork/posdao-contracts/releases/tag/v0.1.9

Checklist for your Pull Request (PR)

@varasev varasev requested a review from vbaranov December 1, 2020 12:07
instead of stake and addPool functions which are not supported by the bridged STAKE token contract on xDai
@varasev varasev force-pushed the va-staking-dapp-transferAndCall branch from 795e4e8 to f8e9f8b Compare December 1, 2020 12:10
@coveralls
Copy link

coveralls commented Dec 1, 2020

Pull Request Test Coverage Report for Build f8e9f8b4f3ab3464e0b633a6518e21dc51b9169e-PR-3498

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.5%) to 66.99%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/channels/stakes_channel.ex 21 0%
Totals Coverage Status
Change from base Build 522fa5a5edbfa052a20213fd6ec7d0808497f71c: 1.5%
Covered Lines: 2070
Relevant Lines: 3090

💛 - Coveralls

@varasev
Copy link
Contributor Author

varasev commented Dec 2, 2020

Now this PR can be approved and merged - we released a new version of the StakingAuRa contract: https://github.com/poanetwork/posdao-contracts/releases/tag/v0.1.9

@vbaranov vbaranov merged commit a4b04d3 into master Dec 2, 2020
@vbaranov vbaranov deleted the va-staking-dapp-transferAndCall branch December 2, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants