Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the size of js bundles #4701

Closed
wants to merge 3 commits into from
Closed

Reduced the size of js bundles #4701

wants to merge 3 commits into from

Conversation

carterqw2
Copy link
Contributor

@carterqw2 carterqw2 commented Sep 28, 2021

GitHub keywords to close any associated issues

Motivation

Including the staking page to the app.js bloats all the js bundles with unnecessary web3 dependency.

Before:
image

After:
image

Changelog

Enhancements

Optimizes the size of the code highlighting script by removing unnecessary dependencies and including only relevant languages to the build. And fixes the 404 issue for the script on the raw traces tab.

Checklist for your Pull Request (PR)

@vbaranov vbaranov mentioned this pull request Feb 8, 2022
6 tasks
@vbaranov
Copy link
Member

vbaranov commented Feb 8, 2022

@carterqw2 thank you, I finalized this PR by fixing js adding for staking dapp in #5172. I am closing the current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants