Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BeaconProxy pattern #4807

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Oct 25, 2021

Close #4770

Changelog

Enhancements

  • Added support for BeaconProxy smart-cotract pattern

If some smart-contract (BeaconProxy) has address (pointing to the Beacon) at the storage slot bytes32(uint256(keccak256('eip1967.proxy.beacon')) - 1, then we call implementation() method from the Beacon. We consider address returned by implementation() at the Beacon contract as address of the implementation of BeaconProxy. If call for some reason failed, we return address of the Beacon as the implementation.

Checklist for your Pull Request (PR)

@nikitosing nikitosing force-pushed the np-add-support-for-beacon-proxy-pattern branch from cf49df7 to ec4a458 Compare October 25, 2021 08:37
@nikitosing nikitosing requested a review from vbaranov October 29, 2021 10:15
@nikitosing nikitosing force-pushed the np-add-support-for-beacon-proxy-pattern branch 4 times, most recently from 2ab36d3 to 15123b4 Compare October 29, 2021 17:19
@vbaranov vbaranov force-pushed the np-add-support-for-beacon-proxy-pattern branch from 15123b4 to 7365cf7 Compare November 3, 2021 12:01
@vbaranov vbaranov merged commit 6e550d7 into master Nov 3, 2021
@vbaranov vbaranov deleted the np-add-support-for-beacon-proxy-pattern branch November 3, 2021 12:15
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Nov 3, 2021
…-beacon-proxy-pattern

Add support for BeaconProxy pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon proxy doesn't point to correct implementation
2 participants