Fix read contract and change tx count #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility issue with smart contract interaction
nikitosing
changed the title
vbaranov
reviewed
Oct 21, 2022
vbaranov
reviewed
Oct 22, 2022
| @@ -962,6 +962,17 @@ defmodule Explorer.Chain do | |||
| Repo.aggregate(to_address_query, :count, :hash, timeout: :infinity) | |||
| end | |||
|
|
|||
| @spec address_hash_to_transaction_count(Hash.Address.t()) :: non_neg_integer() | |||
| def address_hash_to_transaction_count(address_hash) do | |||
There was a problem hiding this comment.
The naming is incorrect. Since it accounts all transactions on address (to/from), I would suggest changing the naming of the function to address_hash_all_transaction_count
| @@ -2447,17 +2458,7 @@ defmodule Explorer.Chain do | |||
|
|
|||
| @spec address_to_transaction_count(Address.t()) :: non_neg_integer() | |||
| def address_to_transaction_count(address) do | |||
There was a problem hiding this comment.
It is worth changing the naming of the function since now it accounts all transactions on the address.
vbaranov
previously approved these changes
Oct 22, 2022
vbaranov
dismissed
their stale review
Some functions still should be re-named (see review comments)
vbaranov
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5738
Close #5518
Changelog
Checklist for your Pull Request (PR)
CHANGELOG.mdwith this PRmasterin the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.