Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of proxy contracts patterns detection: existing popular EIPs to the top of the list #8882

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 24, 2023

#8758

Motivation

Well-known standards (like EIP-1167, EIP-1967, EIP-1822) should have more priority before others.

Changelog

Put next piorities for proxy contracts detection:

  1. EIP-1167 (internal research shows, most of the proxy-contracts follows this pattern)
  2. EIP-1967
  3. EIP-1822
  4. All others

we also not only adding priorities but testing pattern match sequentionally for first 3 standards (if pattern matches, we do not run logic for the next pattern - this should lead to reducing the number of requests to the node).

Fix for EIP-1967 beacon proxy pattern detection.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-change-proxy-contracts-priorities branch 2 times, most recently from 212ec38 to b9f799d Compare November 24, 2023 16:21
@vbaranov vbaranov requested a review from varasev November 27, 2023 09:29
@vbaranov vbaranov merged commit fb2a1fc into master Dec 4, 2023
41 checks passed
@vbaranov vbaranov deleted the vb-change-proxy-contracts-priorities branch December 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants