WIP: Collateral fees only should not get worse when you add more collateral #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidator: split TCS triggering and liquidation job Concurrent execution of candidate lookup and tx building/sending - Also added an health assertion IX to protect liqor in multi liquidation scenario - And a timeout for jupiter v6 queries (avoid blocking liquidation because of slow TCS)
…ing at every try if one token is having an issue (blockworks-foundation#921)
…oundation#924) * liquidator: forcefully exit process if snapshot job die * client: return snapshot_job join handle so it can be watched for early unexpected exit
…n#926) liquidator: add a sequence check in rebalancing
liquidator: add sanctum swap
…ion#939) This is necessary for new liquidator feature of rebalancing using limit orders: We need to close the token and market slot so that it's available for new liquidation, but at the same time, it's possible that the min order quantity for a given market is still bigger than allowed max withdrawal.
…ion#938) liquidator: rebalance with limit order
Co-authored-by: CanardMandarin <thibault.marboud@gmail.com>
Co-authored-by: Tyler <tjshipe@gmail.com> Co-authored-by: Christian Kamm <mail@ckamm.de> Co-authored-by: Serge Farny <serge.farny@gmail.com> Co-authored-by: microwavedcola1 <microwavedcola@gmail.com>
Co-authored-by: microwavedcola1 <microwavedcola@gmail.com>
This ensures casts of local variables don't run into alignment differences.
…it orders for rebalancing (blockworks-foundation#956)
ckamm
reviewed
May 22, 2024
| @@ -93,7 +113,24 @@ pub fn token_charge_collateral_fees(ctx: Context<TokenChargeCollateralFees>) -> | |||
| continue; | |||
| } | |||
|
|
|||
| let fee = token_balance * scaling * I80F48::from_num(bank.collateral_fee_per_day); | |||
| let token_balance = token_position.native(&bank); | |||
There was a problem hiding this comment.
read the balance from the token_balances array here - position.native() doesn't include reserved serum/obv2 amounts, perp amounts etc
microwavedcola1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.