Got Users screen (almost) working with FluentNHibernate! #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1MrKer
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Looks good to me. The strongly typed mappings of Fluent NHibernate in contrast with XML is big improvement.
Id's to Guid's I think is great too.
Why are EffectiveStartedOn/By, EffectiveModifiedOn/By, EffectiveEndedOn/By nullable in BaseEntity where they are not nullable (except for EffectiveEndedBy) in the rest of code and database?
added 2 commits
December 24, 2018 19:55
- Upgraded to dotnet core 2.2. - Replaced Buefy (WebUI) by Quasar-Framework. - (Re)Introduced Typescript and finally got it working with Vue and Quasar. - Fixed Gerard's review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to speed up development I've take the opportunity to check out FluentNHibernate (https://github.com/FluentNHibernate/fluent-nhibernate) as a replacement for Dapper. This in order to worry less about associations that an ORM like NHibernate can take care off.
I choose FluentNHibernate because of the type safety checks etc.
Also using the AutoMapping feature of FluentNHibernate so only Entity declarations and only Mappings to override when needed.
Feel free to comment on this!
It is a special feature branch so it can be skipped if someone feels the need!