Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Replaced with the logos #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replaced with the logos #419

wants to merge 1 commit into from

Conversation

dudikulz
Copy link

Changes

[Describe changes here]

Screenshots

[Add screenshots or GIFs here]

Checklist

  • if changes filter/search functionality, adds or updates unit tests
  • if adds a new page, adds accessibility tests
  • if adds a new page or new interaction, adds e2e test
  • if adds a new page or new interaction, sends google analytics events and updates GA doc
  • if changes filter functionality, updates filters doc

Fixes [link to asana ticket here]

@dudikulz dudikulz requested review from a team as code owners April 20, 2023 14:57
@jeffmaher jeffmaher temporarily deployed to ownpath-pr-419 April 20, 2023 14:57 Inactive
@alex-cds
Copy link

Nice work, @dudikulz!

On mobile, one section ends (with the link) and the following section appears very close to the link in last section. I would like to add more white space between, as shown in this screenshot. Can you make that area about 24px (or use your best judgement. Thank you!!

Screenshot_20230420-115831

@dudikulz dudikulz added the release-minor Change that adds something new, but doesn't modify existing user flows or break existing functions label Apr 20, 2023
tristanvanech
tristanvanech approved these changes Apr 20, 2023
View reviewed changes
Copy link

@tristanvanech tristanvanech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want the padding above and below these components to be the same? Right now there is a lot more space on bottom

jlhogan
jlhogan approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@jlhogan jlhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tristanvanech tristanvanech tristanvanech approved these changes

@jlhogan jlhogan jlhogan approved these changes

@alex-cds alex-cds Awaiting requested review from alex-cds

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-minor Change that adds something new, but doesn't modify existing user flows or break existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dudikulz @alex-cds @tristanvanech @jlhogan @jeffmaher