Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asmund Tokheim tokheim@outlook.com
*Issue number of the reported bug or feature request: #56
Describe your changes
This introduces a root level dockerfile to build a docker image along with github actions to release the container. Just like the author of #56 I'd really need a docker image to be published in order to make use of this very promising project. The docker job is mostly based on the plain example in https://github.com/docker/metadata-action, and should push versioned images whenever you tag the repo. Still there's a lot of customization options you might want to do, so merely a suggestion from me.
Testing performed
I've tested the new dockerfile locally to be working. I also tested the github action on my branch, but haven't published any images, as that seemed like I was overstepping. You can see the result in https://github.com/tokheim/amqpprox/runs/4061595492
Additional context
Before merging you will need to change the image name, and add
DOCKERHUB_USERNAME
andDOCKERHUB_TOKEN
secrets.