BackendStore: Remove (ip,port) -> Backend mapping #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in bloomberg#63, the extra mapping of (ip, port) -> Backend prevents inserting two backends with different names but the same port, which will break a very common configuration. There is no usage of this extra BackendStore mapping, outside of unit tests. An (internal) git history search for `git log -S lookup -p` also suggests there has never been any usage of this method. Let's remove it & fix this behaviour - thanks for the report @kriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #63, the extra mapping of (ip, port) -> Backend prevents
inserting two backends with different names but the same port, which
will break a very common configuration.
There is no usage of this extra BackendStore mapping, outside of unit
tests.
An (internal) git history search for
git log -S lookup -palso suggeststhere has never been any usage of this method.
Let's remove it & fix this behaviour - thanks for the report @kriptor
Closes #63