Make MaybeSecureSocketAdapter::isSecure() private #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamncasey
force-pushed
the
socketsecure
branch
4 times, most recently
from
78ca3de to
d917a2f
Compare
This is only used for something which could happen upfront, so I moved some things around to make this the case. I made this change when I thought we'd want to template this class on whether it was tls or not. Since beast::basic_stream isn't going to work for us it isn't necessary anymore, but I thought it was still useful
Chinmay1412
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only used for something which could happen upfront, so I moved
some things around to make this the case.
I made this change when I thought we'd want to template this class on
whether it was tls or not due to integrating with boost::beast::basic_stream,
but I've since figured out that isn't going to help us here so the next change isn't
needed. I thought this commit was still useful to tidy up the interface.