Start sending appropriate error message to the clients, if the broker mapping is not configured for particular vhost #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhoy
reviewed
May 20, 2022
| driveTo(5); | ||
|
|
||
| EXPECT_TRUE(session->finished()); | ||
| } |
… mapping is not configured for particular vhost
Chinmay1412
force-pushed
the
connection-selector
branch
from
36b3658 to
5412802
Compare
adamncasey
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
acquireConnectionfunction inConnectionSelectorclass, which basically performs farm and backend mapping check for connecting clients during initial handshake. And once it is successful, the Session class starts connecting to the broker.And in case of failure, it immediately close the socket without notifying anything on client side. So this PR sends the Close method with appropriate message to the client before socket closure, so that client can know the reason of sudden disconnection. We might get different errors while performing broker mapping check, but clients will not be aware about the terms. So it is a good idea to send common error message to the clients.
It seems we can add more checks in
acquireConnection, before initiating handshake with broker. So this PR also changes the name of the implementation class to represent wider scope of the class. And the PR is also modifying interface class name to represent explicitly interface e.g.ConnectionSelectorInterface.