boost::asio::io_service -> boost::asio::io_context #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinmay1412
approved these changes
May 27, 2022
|
I guess, we can change the variable name from |
adamncasey
force-pushed
the
iosioc
branch
2 times, most recently
from
fb9c977 to
3bde9d8
Compare
I think asio renamed this as part of aligning with the networking TS This might also help us move to that if it's ever standardised.
Chinmay1412
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_service is a deprecated name, I think asio renamed this as part of aligning with the networking TS (possibly coming in C++23? who knows). This likely isn't the only thing which changed, but it stands out when reading the codebase. https://www.boost.org/doc/libs/1_79_0/doc/html/boost_asio/net_ts.html is a reference if anyone's interested