Remove usage of anonymous namespace in header file #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinmay1412
approved these changes
May 26, 2022
There aren't really any benefits of this, and it has caused some issues for us in the past. Cleaning up for an internal ticket
adamncasey
force-pushed
the
anonnamespaceheader
branch
from
b555a05 to
44cf386
Compare
Chinmay1412
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't many benefits of this, and the behaviour of anonymous namespaces in header files isn't obvious. This has caused some issues for us in the past. Cleaning up for an internal ticket