Limit reason field to 255 characters in authResponse, while sending close method to amqp clients #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lose method to amqp clients
adamncasey
approved these changes
Jun 8, 2022
| true, Reply::Codes::access_refused, reason); | ||
| true, | ||
| Reply::Codes::access_refused, | ||
| reason.substr(0, sendSize)); |
There was a problem hiding this comment.
It's nice that this is substr on string_view 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we are not restricting reason field in authResponse protobuf, while communicating with external service to authenticate clients. Because of that if the external service sends more than 255 characters in reason field, the amqpprox will not be able to encode the Close connection method properly and will not be able to send the Close method to amqp client. The Close connection method's reason(reply-text) field is defined as short string(not more than 255 characters) in the AMQP 0.9.1 protocol. So this PR actively limit the number of characters in the reason field. And in this way, the client will at-least get the close method, otherwise amqpprox restrict that method from sending because of 255 characters limit.