Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start unit testing MaybeSecureSocketAdaptor #93

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

adamncasey
Copy link
Contributor

This commit changes MaybeSecureSocketAdaptor to template a few critical types which allows us to write unit tests against some of it's behaviours

In theory this could probably also replace the SocketIntercept things, which were a nice solution when the implementation of this class passed straight through to the asio types. I didn't look into what we'd need to do to replace that just yet.

Since working around some asio bugs #69 and adding support for data rate limits #88 the MaybeSecureSocketAdaptor class has expanded enough that we should be writing unit tests for it - and probably should have done so before now.

This commit changes MaybeSecureSocketAdaptor to template a few critical
types which allows us to write unit tests against some of it's behaviours

In theory this could probably also replace the SocketIntercept things, which
were a nice solution when the implementation of this class passed straight through
to the asio types.

Since working around some asio bugs bloomberg#69
and adding support for data rate limits bloomberg#88
the MaybeSecureSocketAdaptor class has expanded enough that we should
be writing unit tests for it - and probably should have done so before now.
@adamncasey adamncasey requested a review from willhoy October 18, 2022 15:43
@willhoy willhoy merged commit 554c0eb into bloomberg:main Oct 19, 2022
@adamncasey adamncasey deleted the mssatests branch October 19, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants