mqbblp::ClusterCatalog: Check incompatibility between CSL and FSM mod…

…es (#421) Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
bloomberg · Sep 19, 2024 · 44b4360 · 44b4360
1 parent 6044740
commit 44b4360
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/groups/mqb/mqbblp/mqbblp_clustercatalog.cpp b/src/groups/mqb/mqbblp/mqbblp_clustercatalog.cpp
@@ -153,6 +153,13 @@ int ClusterCatalog::createCluster(bsl::ostream& errorDescription,
         // 1. Fetch the cluster definition
         const mqbcfg::ClusterDefinition& clusterDefinition =
             *clusterDefinitionIter;
+        if (clusterDefinition.clusterAttributes().isFSMWorkflow() &&
+            !clusterDefinition.clusterAttributes().isCSLModeEnabled()) {
+            errorDescription << "Cluster ('" << name
+                             << "') has incompatible CSL and FSM modes, not "
+                                "creating cluster.";
+            return (rc * 10) + rc_FETCH_DEFINITION_FAILED;  // RETURN
+        }
 
         // 2. Create the mqbnet::Cluster
         rc = createNetCluster(errorDescription,

diff --git a/src/groups/mqb/mqbmock/mqbmock_cluster.cpp b/src/groups/mqb/mqbmock/mqbmock_cluster.cpp
@@ -89,6 +89,9 @@ void Cluster::_initializeClusterDefinition(
     BSLS_ASSERT_OPT(!d_isStarted &&
                     "_initializeClusterDefinition() must be called before"
                     " start()");
+    if (isFSMWorkflow) {
+        BSLS_ASSERT_SAFE(isCSLMode);
+    }
 
     d_clusterDefinition.name() = name;