Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShellCheck failures #66

Closed
1 task done
pniedzielski opened this issue Aug 3, 2023 · 0 comments · Fixed by #70
Closed
1 task done

Fix ShellCheck failures #66

pniedzielski opened this issue Aug 3, 2023 · 0 comments · Fixed by #70
Assignees
@pniedzielski
Labels
A-Broker Area: C++ Broker A-Build Area: Build System bug Something isn't working good first issue Good for newcomers

Comments

@pniedzielski
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The new ShellCheck linter job fails on three existing shell scripts in our repository:

  • ./bin/build-ubuntu.sh,
  • ./bin/build-darwin.sh, and
  • ./src/applications/bmqbrkr/run.

Expected Behavior

CI checks should not fail.

Steps To Reproduce

https://github.com/bloomberg/blazingmq/actions/runs/5755158855/job/15602005338

BlazingMQ Version

HEAD

Anything else?

No response
@pniedzielski pniedzielski added bug Something isn't working good first issue Good for newcomers A-Broker Area: C++ Broker A-Build Area: Build System labels Aug 3, 2023
@pniedzielski pniedzielski self-assigned this Aug 3, 2023
@pniedzielski pniedzielski mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pniedzielski pniedzielski

Labels
A-Broker Area: C++ Broker A-Build Area: Build System bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shellcheck failures pniedzielski/blazingmq
1 participant
@pniedzielski