Fix shellcheck failures #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikulimu
previously approved these changes
Aug 4, 2023
Laxonj
approved these changes
Aug 10, 2023
jll63
previously approved these changes
Aug 15, 2023
This patch fixes the warnings that our ShellCheck linter catches on the `build-darwin.sh` file. Most of these changes are about quoting expanded variables, which in our case is generally good: for example, we want to correctly handle the case of a user’s build directory having a space in its full path. In the case of `CMAKE_OPTIONS`, we do this by changing the string variable into an array of strings we can correctly quote, both when creating the array and when expanding it as arguments. Signed-off-by: Patrick M. Niedzielski <patrick@pniedzielski.net>
This patch fixes the warnings that our ShellCheck linter catches on the `build-ubuntu.sh` file. As with the previous patch, the majority of these changes are about quoting expanded variables. Here additionally, we are using a HereDoc as multiline comment for the user to copy and paste, so we disable a linter warning `SC2188` about [redirection missing a command][sc2188] for this line. [sc2188]: https://www.shellcheck.net/wiki/SC2188 Signed-off-by: Patrick M. Niedzielski <patrick@pniedzielski.net>
pniedzielski
force-pushed
the
fix-shellcheck-failures
branch
from
cba4448 to
16bcff6
Compare
hallfox
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #66
Closes #66.
Describe your changes
The incorporation of ShellCheck linting into our CI found some quoting bugs in our shell scripts. This patchset fixes these issues.
Testing performed
Both
build-darwin.shandbmqbrkr/runwere tested. I am unable to testbuild-ubuntu.shwithout access to an Ubuntu machine.Additional context
This PR is a draft, because it will change after the incorporation of #65 and #67.